[pbs-devel] applied-series: [PATCH proxmox-backup v2 1/3] rest-server: cleanup_old_tasks: improve error handling

Thomas Lamprecht t.lamprecht at proxmox.com
Thu Apr 7 14:06:01 CEST 2022


On 28.03.22 09:54, Dominik Csapak wrote:
> by not bubbling up most errors, and continuing on. this avoids that we
> stop cleaning up because e.g. one directory was missing.
> 
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
> changes from v1:
> * ignore only ENOENT error for task log archive dirs,
>   log all other errors
> * use task_log instead of log::errors, this way the task will end on a
>   'WARNINGS' and the user sees that something was wrong with it
>   this also has the advantage that the errors really go into the task
>   log instead of the syslog
> * improve error messages
> 
>  proxmox-rest-server/src/worker_task.rs | 38 ++++++++++++++++++++------
>  src/bin/proxmox-backup-proxy.rs        |  2 +-
>  2 files changed, 30 insertions(+), 10 deletions(-)
> 
>

applied, with the merge conflict from a recent rustfmt resolved and the followup
discussed off-list to fix the off-by-one file deletion the series had, thanks!





More information about the pbs-devel mailing list