[pbs-devel] applied: [PATCH proxmox-backup v7] fix #3854 paperkey import to proxmox-tape

Thomas Lamprecht t.lamprecht at proxmox.com
Wed Apr 6 16:35:25 CEST 2022


On 24.03.22 12:49, Markus Frank wrote:
> added a parameter to the cli for importing tape key via a json-parameter or
> via reading a exported paperkey-file or json-file.
> For this i also added a backupkey parameter to the api, but here it only
> accepts json.
> 
> The cli interprets the parameter first as json-string, then json-file
> and last as paperkey-file.
> 
> functionality:
> proxmox-tape key paperkey [fingerprint of existing key] > paperkey.backup
> proxmox-tape key restore --backupkey paperkey.backup # key from line above
> proxmox-tape key restore --backupkey paperkey.json # only the json
> proxmox-tape key restore --backupkey '{"kdf": {"Scrypt": ...' # json as string
> 
> for importing the key as paperkey-file it is irrelevant, if the paperkey got exported as html
> or txt.
> 
> Signed-off-by: Markus Frank <m.frank at proxmox.com>
> ---

>  src/api2/tape/drive.rs                 | 65 +++++++++++++++++++-------
>  src/bin/proxmox_tape/encryption_key.rs | 59 +++++++++++++++++++++--
>  2 files changed, 102 insertions(+), 22 deletions(-)
> 
>

applied, thanks! While this was OK code-wise I made a not so small followup commit
for some semantic changes, mostly it was for splitting CLI behavior for key-string
vs. key-file again. Would appreciate if you also re-take a look to ensure I did
not botched something in progress.





More information about the pbs-devel mailing list