[pbs-devel] [PATCH proxmox-backup] fix #3613: catalog_shell: include matched dir's contents on restore

[Dylan Whyte]

On 4/6/22 10:26, Dietmar Maurer wrote:
>> On 04/04/2022 6:19 PM Dylan Whyte<d.whyte at proxmox.com>  wrote:
>>
>>   
>> Prior to this, during an interactive restore, if a directory was matched
>> via a pattern match or selection, only the empty directory would be
>> restored, and not its contents.
> Why not simply use "**" if you want to restore a whole tree?

I had originally thought about this, but there are some good reasons for 
the patch:

  * I believe there is an expectation when selecting a directory for
    restore, that you would like for the entire directory to be restored
    (unless any sub-directory is explicitly excluded).
  * The 'select' command doesn't do pattern matching, so it wouldn't be
    able to use '**' to restore the directory. This point doesn't apply
    to 'find' and 'restore --pattern'.
  * With the current implementation, '**' won't restore empty
    sub-directories of a matched directory, in spite of the fact that
    they appear in the match list.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.proxmox.com/pipermail/pbs-devel/attachments/20220406/55d456e2/attachment.htm>