[pbs-devel] [PATCH proxmox-backup 00/12] add 'protected' setting for snapshots

[Fabian Grünbichler]

general looks okay, needs a rebase (so not tested, just read ;))

a few smaller notes on indivual patches

On September 6, 2021 12:57 pm, Dominik Csapak wrote:
> add the means to 'protect' a snapshot against pruning and removal by
> adding a file '.protected' in the snapshot folder
> 
> changes from rfc:
> * added gui parts
> * added tests
> * fixed a bug (that the test uncovered)
> * add pbs client command
> * prevent removal (also during sync)
> 
> Dominik Csapak (12):
>   pbs-datastore: add protection info to BackupInfo
>   pbs-datastore: skip protected backups in pruning
>   add protected info of snapshots to api and task logs
>   tests/prune: add tests for protecteded backups
>   backup/datastore: prevent protected snapshots to be removed
>   pull_store/group: dont try remove locally protected snapshots
>   api2: datastore/delete_group: throw error for partially removed group
>   api2/admin/datastore: add get/set_protection
>   proxmox-backup-client: add 'protected update command'
>   ui: PruneInputPanel: add keepReason 'protected' for protected backups
>   ui: add protected icon to snapshots
>   fix #3602: ui: datastore/Content: add action to set protection status
> 
>  pbs-api-types/src/lib.rs              |   2 +
>  pbs-datastore/src/backup_info.rs      |  20 ++++-
>  pbs-datastore/src/prune.rs            |  17 ++--
>  proxmox-backup-client/src/snapshot.rs |  51 +++++++++++
>  src/api2/admin/datastore.rs           | 116 +++++++++++++++++++++++++-
>  src/backup/datastore.rs               |  37 +++++---
>  src/server/prune_job.rs               |   4 +-
>  src/server/pull.rs                    |  19 ++++-
>  tests/prune.rs                        |  40 ++++++++-
>  www/datastore/Content.js              |  75 +++++++++++++++++
>  www/datastore/Prune.js                |   4 +
>  11 files changed, 355 insertions(+), 30 deletions(-)
> 
> -- 
> 2.30.2
> 
> 
> 
> _______________________________________________
> pbs-devel mailing list
> pbs-devel at lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
> 
> 
>