[pbs-devel] [RFC PATCH proxmox-backup 0/5] add 'protected' setting for snapshots

[Dietmar Maurer]

> On 09/02/2021 8:48 AM Thomas Lamprecht <t.lamprecht at proxmox.com> wrote:
> 
>  
> On 02.09.21 08:45, Dietmar Maurer wrote:
> >>> * would we want to protect also against manual removal ? or
> >>>  'remove-vanished' on sync?
> >>
> >> Would make sense as long as we allow to "unprotect" it, that's how we do it for guests
> >> in PVE too. IMO it's weird/unexpected to mark it protected and allow some API mechanisms
> >> to still remove it.
> > 
> > I would not consider the protected flag for syncs, i.e:
> > - do not sync the protected flag itself
> 
> That I agree (and I did not meant to suggest otherwise).
> 
> > - remove vanished backups even with protected flag set (to be in sync with source)
> 
> That I do not agree, if I marked a snapshot explicitly protected, which
> is a must for the situation to happen with the first point above in mind
> (no syncing of the protection flag itself) then I'm pretty sure that I want
> to keep that snapshot no matter what.

Also OK for me.