[pbs-devel] [RFC PATCH proxmox-backup 0/5] add 'protected' setting for snapshots

Dominik Csapak d.csapak at proxmox.com
Wed Sep 1 10:25:34 CEST 2021


add the means to 'protect' a snapshot against pruning by
adding a file '.protected' in the snapshot folder

sending as RFC because i am not sure about a couple things, and there
is no gui (yet):

* does it make sense to protect a snapshot this way? or would it be
  better to have a 'central' protected list somewhere?
  (sounds not right though..)
* would we want to protect also against manual removal ? or
 'remove-vanished' on sync?
* how should the ui look? do we want *another* button in the content
  view?
* would it make sense to specify this flag on backup creation too?

the finished series would fix #3602

Dominik Csapak (5):
  pbs-datastore: add protection info to BackupInfo
  pbs-datastore: skip protected backups in pruning
  add protected info of snapshots to api and task logs
  api2/admin/datastore: add get/set_protection
  ui: PruneInputPanel: add keepReason 'protected' for protected backups

 pbs-api-types/src/lib.rs         |   2 +
 pbs-datastore/src/backup_info.rs |  20 +++++-
 pbs-datastore/src/prune.rs       |  21 +++---
 src/api2/admin/datastore.rs      | 112 ++++++++++++++++++++++++++++++-
 src/server/prune_job.rs          |   4 +-
 www/datastore/Prune.js           |   4 ++
 6 files changed, 148 insertions(+), 15 deletions(-)

-- 
2.30.2






More information about the pbs-devel mailing list