[pbs-devel] [PATCH proxmox-backup] rest-server: use hashmap for parameter errors

Dominik Csapak d.csapak at proxmox.com
Tue Oct 19 13:09:27 CEST 2021


our ui expects a map here with 'field: "error"'. This way it can mark
the relevant field as invalid and correctly shows the complete error
message

Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
---
 proxmox-rest-server/src/formatter.rs | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/proxmox-rest-server/src/formatter.rs b/proxmox-rest-server/src/formatter.rs
index 6d050997..cb5774d5 100644
--- a/proxmox-rest-server/src/formatter.rs
+++ b/proxmox-rest-server/src/formatter.rs
@@ -1,4 +1,5 @@
 //! Helpers to format response data
+use std::collections::HashMap;
 
 use anyhow::{Error};
 use serde_json::{json, Value};
@@ -144,15 +145,14 @@ impl  OutputFormatter for ExtJsFormatter {
     fn format_error(&self, err: Error) -> Response<Body> {
 
         let message: String;
-        let errors;
+        let mut errors = HashMap::new();
 
         if let Some(param_err) = err.downcast_ref::<ParameterError>() {
-            errors = param_err.errors().iter()
-                .map(|(name, err)| format!("parameter '{}': {}", name, err))
-                .collect();
+            for (name, err) in param_err.errors().iter() {
+                errors.insert(name, err.to_string());
+            }
             message = String::from("parameter verification errors");
         } else {
-            errors = vec![];
             message = err.to_string();
         }
 
-- 
2.30.2





More information about the pbs-devel mailing list