[pbs-devel] applied: [PATCH proxmox-backup v2 2/2] backup-proxy: fix api log reopen send_command calls

Thomas Lamprecht t.lamprecht at proxmox.com
Mon Oct 11 14:57:38 CEST 2021


On 11.10.21 14:14, Dominik Csapak wrote:
> if we give a string to send_command, it gets to the receiving end as a
> string again (not an object), and the command fails with:
> 
> 'unable to parse parameters (expected json object)'
> 
> Instead, use send_raw_command which expects the string. Also refactor
> the identical command strings.
> 
> Fixes: commit 45b8a0327f21f048bb4384bafc292954358b5651
> 
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
> changes from v1:
> * include fixed commit in commit message
> * use send_raw_command with the original strings
> 
>  src/bin/proxmox-backup-proxy.rs | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
>

applied this one for now but dropped the factoring out of the command, not really
worth it IMO and I prefer to keep (initial) change noise small for those things, thanks!

Also did a semantic backport to the stable-1 branch, cherry-picking is rather out of
the window with that big bunch of restructuring that happend in the last weeks/months.




More information about the pbs-devel mailing list