[pbs-devel] [PATCH proxmox-backup 1/2] rest-server/worker-task: replace newlines with '\n' in task result

Dominik Csapak d.csapak at proxmox.com
Mon Oct 11 10:35:20 CEST 2021


we parse the task result from the last line, so we should not print a
new line in the task result, else we get an 'unknown' task state

Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
---
alternatively, we could try to parse the task log backwards to find the
result, but that is bit more complicated and costly

 proxmox-rest-server/src/worker_task.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/proxmox-rest-server/src/worker_task.rs b/proxmox-rest-server/src/worker_task.rs
index 51394549..a8899ab9 100644
--- a/proxmox-rest-server/src/worker_task.rs
+++ b/proxmox-rest-server/src/worker_task.rs
@@ -494,7 +494,7 @@ impl TaskState {
         match self {
             TaskState::Error { message, .. } => format!("TASK ERROR: {}", message),
             other => format!("TASK {}", other),
-        }
+        }.replace('\n', "\\n") // no newline in task result
     }
 
     fn from_endtime_and_message(endtime: i64, s: &str) -> Result<Self, Error> {
-- 
2.30.2





More information about the pbs-devel mailing list