[pbs-devel] [PATCH v2 proxmox-backup 0/4] close #3071: maintenance mode for datastores

Hannes Laimer h.laimer at proxmox.com
Wed Oct 6 17:14:53 CEST 2021


v2:
 - check for maintenance now directly in lookup_datastore
 - parameter for checking is now the last acceptable maintenance type,
   description in commit msg of 2nd patch
 - ui cleanup 

Adds a maintenance mode for datatsores. If a datastore is in maintenance
mode it has a maintenance-type and a maintenance-msg.
The type specifies what is still allowed on the ds and what is not.
Currently there are two types: read only and offline. 'read only' prevents
everything that would write something to the ds, but allows to read from
it. 'offline' prevents everything on the datastore, neither operation
that write nor operations that read form the datastore are allowed.
The message is optional and is a short string that describes the reason
for the maintenance, it is shown whenever an operation is prevented due
to the maintenance.

Already running jobs and operations are not affected. Neither are the
modification or creation of jobs, since they just modify a config file
that is stored on the host system.

As Dominik Csapak <d.csapak at proxmox.com> suggested, it might make sense
to prevent setting a maintenance mode while jobs run.


Hannes Laimer (4):
  pbs-api-types: add maintenance type and msg to ds config
  pbs-datastore: add check for maintenance to lookup_datastore
  api2: make maintenance type and msg updatable/deletable
  ui: add maintenance to datastore options

 pbs-api-types/src/datastore.rs       | 33 ++++++++++++++++++
 pbs-datastore/src/datastore.rs       | 14 ++++++--
 pbs-datastore/src/snapshot_reader.rs |  6 +++-
 src/api2/admin/datastore.rs          | 44 ++++++++++++------------
 src/api2/backup/mod.rs               |  2 +-
 src/api2/config/datastore.rs         |  8 +++++
 src/api2/pull.rs                     |  4 +--
 src/api2/reader/mod.rs               |  6 ++--
 src/api2/status.rs                   |  6 ++--
 src/api2/tape/backup.rs              |  4 +--
 src/api2/tape/restore.rs             |  6 ++--
 src/bin/proxmox-backup-proxy.rs      |  6 ++--
 src/server/prune_job.rs              |  2 +-
 src/server/verify_job.rs             |  4 +--
 www/Makefile                         |  1 +
 www/Utils.js                         |  7 ++++
 www/datastore/OptionView.js          |  9 +++++
 www/window/MaintenanceOptions.js     | 51 ++++++++++++++++++++++++++++
 18 files changed, 168 insertions(+), 45 deletions(-)
 create mode 100644 www/window/MaintenanceOptions.js

-- 
2.30.2





More information about the pbs-devel mailing list