[pbs-devel] [PATCH proxmox-backup v2 4/5] ui: tape/window/TapeRestore: enabling selecting multiple snapshots

[Thomas Lamprecht]

On 14.05.21 14:59, Dominik Csapak wrote:
> by including the new snapshotselector. If a whole media-set is to be
> restored, select all snapshots
> 
> to achieve this, we drop the 'restoreid' and 'datastores' properties
> for the restore window, and replace them by a 'prefilter' object
> (with 'store' and 'snapshot' properties)
> 
> to be able to show the snapshots, we now have to always load the
> content of that media-set, so drop the short-circuit if we have
> the datastores already.
> 
> also to improve space-usage, shift the datastores mapping grid in the
> right column, and all non datastore related options in the left one,
> showing the snapshot grid below
> (the datastore mapping is now limited to 150px; ~3 datastores, and scrollable)
> 
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
>  www/tape/BackupOverview.js     | 27 +++-------
>  www/tape/window/TapeRestore.js | 99 ++++++++++++++++++----------------
>  2 files changed, 61 insertions(+), 65 deletions(-)
> 


I tried it now a bit, also with multi-datastores, I found one thing quite confusing:

1. restore whole mediaset with multiple datastore
2. set mapping for only one datastore and no default datastore
-> the snapshots on other datastore are still selected, but for the user this is highly
   confusing, as they cannot know about what will happen to them? Not restored, used in
   the same mapping, ..

Deselection of those snapshots without a datastore-map is not an option, as the next
datastore-mapping could be still configured immediately after setting the first one.


IIRC, you mentioned the idea of a multi-step wizard, that could solve this here more
nicely. I'd do two steps:

1. Show "Media Set" and "Media Set UUID" at the top, then only the snapshot grid below
2. Now we know all possible datastores from the selected snapshot list, so the
   datastore-map-grid can be filtered to only show relevant ones.
   
The drive could go in either step, at least wouldn't be completely off.

That would separate the "what do I need to restore" from the "where do I want to put it"
a bit and two simpler sequential panels are probably easier to grasp for a user than
one rather complex one.

What do you think?