[pbs-devel] [PATCH proxmox-backup] proxmox-restore-daemon: keep daemon active during extract api call

Thomas Lamprecht t.lamprecht at proxmox.com
Fri May 14 10:54:37 CEST 2021


On 14.05.21 10:42, Dominik Csapak wrote:
> we only called watchdog_ping on the start of an api call, which meant
> that if a single zip/pxar download took longer than 10 minutes
> (which can happen on larger vms/slower connections), we shut-down
> the vm and cancelled the download.
> 
> instead, spawn a second future, that polls both a sleep and the extract
> handle, and ping the watchdog every 60 seconds
> 

This is known and Stefan send a patch for this last week[0], which was OK but
delayed due to the tokio DuplexStream bug he also fixed where we did not
decided then if we still use his workaround after upstream already merged
the fix.

IIRC your approach has some drawbacks, especially without the workaround fixed,
but just some fain memory - in any way I'll go for Stefan's series.

[0]: https://lists.proxmox.com/pipermail/pbs-devel/2021-May/003106.html





More information about the pbs-devel mailing list