[pbs-devel] [PATCH backup 5/7] proxy: implement 'reload-certificate' command

Wolfgang Bumiller w.bumiller at proxmox.com
Wed May 12 11:17:13 CEST 2021


> On 05/12/2021 11:13 AM Dietmar Maurer <dietmar at proxmox.com> wrote:
> 
>  
> > > Another way would be to avoid the select inside the loop, for example
> > > by using an Atomic counter (cert is loaded on next accept, not immediately)
> > 
> > That would also work. Should the reload command handler also log then, so it is visible that there's a pending reload?
> > 
> > Another possibility is wrapping the Arc<SslAcceptor> in an AtomicBox (though that's not in the std lib, only AtomicPtr, but it should be easy to write one, (and there's an atomic_box crate)).
> 
> Instead, I use Arc<Mutex<SslAcceptor>>:

right we only need to get the context from the acceptor

lgtm





More information about the pbs-devel mailing list