[pbs-devel] [PATCH proxmox-backup] ui: tape/BackupOverview: add 'restore partial' button

[Thomas Lamprecht]

On 12.05.21 08:22, Dominik Csapak wrote:
> On 5/11/21 18:17, Thomas Lamprecht wrote:
>> On 11.05.21 14:42, Dominik Csapak wrote:
>>> this opens the restore window, but with a snapshot selector, so that
>>> the user can select the snapshots to restore
>>>
>>> includes a textfield for basic filtering
>>
>>
>> why isn't that handled directly in the restore window, without extra buttons?
>> Could possibly be a radio group there.
> 
> yes you're right, that'll much better, though i would not do a radio button, but maybe only a checkbox '[] Select snapshots' which
> enables the selection grid?
> 
> we could then open that window with a preselected(and filtered?) list when the user clicks on the 'restore single snapshot' button?
> 
> does that make sense?

yes, can make sense - would be related to the backup-job edit window in PVE.

IMO slightly better than radio-group/checkbox as it removes a UI control
element completely, so less choice/confusion, but without scarifying flexibility,
so IMO a good idea.


>>
>> I really want to avoid many buttons in places like top-bars, makes it crowded
>> and confusing..
>>
>> Also, why doesn't this uses action buttons for those things like the content
>> tree? IMO we should try to be consistent with UX, cross-product this may be
>> hard and lots of work, but I do not see any excuse for intra-product consistency
>> (especially on rather simple UIs like PBS, compared to PVE).
> 
> mhmm sounds good, i'd do an action column where each media set and
> snapshot gets a restore button, and for single snapshots i preselect
> like i mentioned above.. does that make sense?
> 

yeah, if the others are still shown for the single snapshot I'd try to scroll
it in view or order it first though, so its immediately visible. We could even
order selected generally first by default, just an idea though...

> (we could probably do a restore button on every level in the tree,
> and preselect accordingly, though i am unsure if that does not
> get too confusing and if its even helpful...)
>