[pbs-devel] [PATCH proxmox-backup v5 0/5] tape: single snapshot restore

Dominik Csapak d.csapak at proxmox.com
Tue May 11 12:50:02 CEST 2021


should be an ok and working state, nothing
obvious is missing or not working besides
* gui for multiselection (i have an idea, will send patches later)

changes from v4:
* change variable names from '_list' to '_map' or '_hash' if they
  are not a list
* use BTreeMap for things we want to have sorted
* better logging
* better error handling
* rebase on master
(all changes are in patch 2/5)

changes from v3:
* split the refactoring of the 'restore_worker' into its own patch
* renamed 'restore_worker' to 'restore_full_worker' and
  'restore_single_worker' to 'restore_list_worker' (hopefully those
  names are clearer?)
* rebased on master

changes from v2:
* added schema for snapshot
* integrated with the normal restore api call and command
* added completion helper for proxmox-tape
* added small api-viewer patch to improve the '<array>' type text
* rebase on master

changes from v1:
* use parallel handler for chunk restore
* rebase on master
* add patch to return manifest from try_restore_snapshot_archive
* using of Arc<WorkerTask> like we do now in rest of the file



Dominik Csapak (5):
  api2/tape/restore: refactor restore code into its own function
  api2/tape/restore: add optional snapshots to 'restore'
  tape/inventory: add completion helper for tape snapshots
  bin/proxmox-tape: add optional snapshots to restore command
  ui: tape: add single snapshot restore

 src/api2/tape/restore.rs       | 682 +++++++++++++++++++++++++++++----
 src/bin/proxmox-tape.rs        |  13 +-
 src/tape/inventory.rs          |  36 ++
 www/tape/BackupOverview.js     |  41 ++
 www/tape/window/TapeRestore.js |  25 ++
 5 files changed, 719 insertions(+), 78 deletions(-)

-- 
2.20.1






More information about the pbs-devel mailing list