[pbs-devel] [PATCH proxmox-backup v2 0/8] tape: single snapshot restore

Dominik Csapak d.csapak at proxmox.com
Wed May 5 12:09:10 CEST 2021


v2 of the series, some small parts are still in-progress/unfinished:
* api path is (imho) not optimal, but did not find something better
  (integration into existing restore call gets ugly fast...)
* schema for the snapshot list is not done yet (but not hard..)
* gui for multiselection is not done yet (have to think about how
  we do that for a good ux)

questions still to answer:
 do we really want to have the ability to restore multiple 'single' snapshots
 in one go? if not, it would drastically simplify the code

changes from v1:
* use parallel handler for chunk restore
* rebase on master
* add patch to return manifest from try_restore_snapshot_archive
* using of Arc<WorkerTask> like we do now in rest of the file

@Dietmar, could you test on real tape hardware if it works correctly as-is?

Dominik Csapak (8):
  tape/drive: add 'move_to_file' to TapeDriver trait
  tape/media_catalog: add helpers to look for snapshot/chunk files
  api2/tape/restore: factor out check_datastore_privs
  api2/tape/restore: remove unnecessary params from
    (try_)restore_snapshot_archive
  api2/tape/restore: return backup manifest in
    try_restore_snapshot_archive
  api2/tape/restore: add 'restore-single' api path
  bin/proxmox-tape: add restore-single command to proxmox-tape
  ui: tape: add single snapshot restore

 src/api2/tape/mod.rs           |   1 +
 src/api2/tape/restore.rs       | 668 +++++++++++++++++++++++++++++++--
 src/bin/proxmox-tape.rs        |  62 +++
 src/tape/drive/lto/mod.rs      |   4 +
 src/tape/drive/mod.rs          |   3 +
 src/tape/drive/virtual_tape.rs |  22 ++
 src/tape/media_catalog.rs      |  20 +
 www/tape/BackupOverview.js     |  41 ++
 www/tape/window/TapeRestore.js |  26 ++
 9 files changed, 821 insertions(+), 26 deletions(-)

-- 
2.20.1






More information about the pbs-devel mailing list