[pbs-devel] applied: [REBASED v2 backup 0/9] rebased and reordered acme implementation

Dietmar Maurer dietmar at proxmox.com
Tue May 4 09:57:32 CEST 2021


applied with minor cleanups

On 5/3/21 11:39 AM, Wolfgang Bumiller wrote:
> Only minor changes, a split and some merges:
>
> * moved the validation plugin implementations from config::acme::plugin
>    to acme::plugin, in order to separate the config again.
> * dropped the `read_lock` functions and renamed `write_lock` -> `lock`
> * removed some leftover commented out code
> * changed lock timeouts to 10s like in most other config parts
> * lock file name consistency ('.lock' -> '.lck')
> * kept AccountName for now, we still need to discuss how to
>    approach this definitively
> * for less noise I merged the patches at the end of the series into the
>    earlier ones, since they're mostly fixup commits:
>    - creating acme directories before placing files in there
>    - validate config before writing
>    - pipe plugin output to task log
>    - make account name optional in api call
>    Also: standalone validation, since introducing dns validation together
>    with the plugin config but adding this one later isn't consistent
>    anyway.
>
> Wolfgang Bumiller (9):
>    add acme config
>    add acme client
>    add node config
>    add config/acme api path
>    add node/{node}/certificates api call
>    add node/{node}/config api path
>    add acme commands to proxmox-backup-manager
>    ui: add certificate & acme view
>    daily-update: check acme certificates
>
>   src/acme/client.rs                     | 673 +++++++++++++++++++++++
>   src/acme/mod.rs                        |   5 +
>   src/acme/plugin.rs                     | 299 ++++++++++
>   src/api2/config.rs                     |   2 +
>   src/api2/config/acme.rs                | 725 +++++++++++++++++++++++++
>   src/api2/node.rs                       |   4 +
>   src/api2/node/certificates.rs          | 579 ++++++++++++++++++++
>   src/api2/node/config.rs                |  80 +++
>   src/bin/proxmox-backup-manager.rs      |   1 +
>   src/bin/proxmox-daily-update.rs        |  30 +-
>   src/bin/proxmox_backup_manager/acme.rs | 415 ++++++++++++++
>   src/bin/proxmox_backup_manager/mod.rs  |   2 +
>   src/config.rs                          |  20 +-
>   src/config/acme/mod.rs                 | 273 ++++++++++
>   src/config/acme/plugin.rs              | 213 ++++++++
>   src/config/node.rs                     | 202 +++++++
>   src/lib.rs                             |   2 +
>   www/Makefile                           |   1 +
>   www/NavigationTree.js                  |   6 +
>   www/config/CertificateView.js          |  80 +++
>   20 files changed, 3609 insertions(+), 3 deletions(-)
>   create mode 100644 src/acme/client.rs
>   create mode 100644 src/acme/mod.rs
>   create mode 100644 src/acme/plugin.rs
>   create mode 100644 src/api2/config/acme.rs
>   create mode 100644 src/api2/node/certificates.rs
>   create mode 100644 src/api2/node/config.rs
>   create mode 100644 src/bin/proxmox_backup_manager/acme.rs
>   create mode 100644 src/config/acme/mod.rs
>   create mode 100644 src/config/acme/plugin.rs
>   create mode 100644 src/config/node.rs
>   create mode 100644 www/config/CertificateView.js
>





More information about the pbs-devel mailing list