[pbs-devel] applied: [PATCH backup] d/postinst: restart when updating from older version

Thomas Lamprecht t.lamprecht at proxmox.com
Thu Mar 11 09:58:21 CET 2021


Else one has quite a terrible UX when installing from 1.0 ISO and
then upgrading to latest release..

commit 0ec79339f7aebf9 for the fix and some other details

Signed-off-by: Thomas Lamprecht <t.lamprecht at proxmox.com>
---

As without this we always get a hanging upgrade when doing the insitial
upgrade after installation from the ISO, that's a no go, and restart is
better than user botching around, not really knowing what the issue is
and needing to do a stop+start or restart anyway.

 debian/postinst | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/debian/postinst b/debian/postinst
index 7af49952..eb79851f 100644
--- a/debian/postinst
+++ b/debian/postinst
@@ -12,7 +12,14 @@ case "$1" in
 	# modeled after dh_systemd_start output
 	systemctl --system daemon-reload >/dev/null || true
 	if [ -n "$2" ]; then
-		_dh_action=try-reload-or-restart
+		if dpkg --compare-versions "$2" 'lt' '1.0.7-1'; then
+			# there was an issue with reloading and systemd being confused in older daemon versions
+			# so restart instead of reload if upgrading from there, see commit 0ec79339f7aebf9
+			# FIXME: remove with PBS 2.1
+			_dh_action=try-restart
+		else
+			_dh_action=try-reload-or-restart
+		fi
 	else
 		_dh_action=start
 	fi
-- 
2.29.2






More information about the pbs-devel mailing list