[pbs-devel] [PATCH proxmox-backup 7/7] manager: don't complete sync job ID on creation

[Fabian Grünbichler]

On July 22, 2021 5:46 pm, Dietmar Maurer wrote:
>> On 07/22/2021 4:35 PM Fabian Grünbichler <f.gruenbichler at proxmox.com> wrote:
>> 
>>  
>> that does not make sense, 
> 
> make sense to me,

ack, maybe that was a bit strongly worded ;)

>> since re-using an existing one leads to an
>> error.
> 
> because it really helps to see what already exists
> 

we don't have that semantic for other completions though, and for sync 
jobs most users will have auto-generated names if they created their 
jobs with the GUI.. creating a datastore does not complete existing 
names, updating/showing/removing/using does. creating a new remote does 
not complete existing remote names, updating/showing/removing/using one 
does. same for users, API tokens - the only other exception that 
completes on creation is adding a new network interface.

but I don't have strong feelings about this (I literally stumbled upon 
this when doing the other patches) - other than that we should  be 
consistent. so if we agree that we want to complete existing identifiers 
when adding new entities, I'd send a separate series adding that to the 
others where it's missing.