[pbs-devel] applied-series: [PATCH proxmox-apt] depend on proxmox 0.12.0, bump version to 0.5.1-1
Thomas Lamprecht
t.lamprecht at proxmox.com
Tue Jul 20 19:25:10 CEST 2021
applied series, had to do a few fixups though:
* bump proxmox-api-macro and proxmox-http as they both use proxmox and are
already present in PBS 1.X based on Buster, so we need some version room for doing
stable updates there
* squashed in d/control updates in proxmox-apt in your commit
* fixed proxmox-backup's d/control, we do not use debcargo anymore there, so it needs to
be adapted manual for now (could and should be automated though)
* fixed the use in openid `src/api2/access/openid.rs` which was probably missed as it's
behind the "openid" cargo "cfg" flag and no full `make deb` or `cargo build --cfg openid`
was done. I squashed the change into your patch, IMO there was no need for a separate
fixup commit here.
One thing I do not really like is the name of the helper, as `open_backup_lockfile` sounds
like it would open the lockfile of a backup (snapshot), but that's not the case.
IMO the backup is irrelevant here, we just have a privileged and unprivileged user,
here it's `backup` in PVE `www-data`, the actual user does not matters much for the
code, and even if the name would still be confusing.
I'd use rather a name like `open_lockfile_unpriv`, but as this is all contained to that one
repo it can be changed at any time, so I applied it as is for now.
ps. the patches are lacking your `Signed-off-by`, no biggie currently, but we try to
add that nonetheless, thanks!
More information about the pbs-devel
mailing list