[pbs-devel] applied-series: [PATCH proxmox-backup 1/2] backup/datastore: refactor chunk inode sorting to the datastore

Thomas Lamprecht t.lamprecht at proxmox.com
Mon Jul 12 06:23:06 CEST 2021


On 18.06.21 11:29, Dominik Csapak wrote:
> so that we can reuse that information
> 
> the removal of the adding to the corrupted list is ok, since
> 'get_chunks_in_order' returns them at the end of the list
> and we do the same if the loading fails later in 'verify_index_chunks'
> so we still mark them corrupt
> (assuming that the load will fail if the stat does)
> 
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
> alternatively, we could return 2 lists, or check after the loop
> for the u64::MAX value, but imho it's ok this way
> 
>  src/backup/datastore.rs | 38 ++++++++++++++++++++++++++++++++++++++
>  src/backup/verify.rs    | 38 +++++++-------------------------------
>  2 files changed, 45 insertions(+), 31 deletions(-)
> 
>

Just for the record, as Dietmar applied this on "Mon Jun 28 12:16:14 2021 +0200", but
I saw no applied mail and as you also still thought this was not in I figured it'll save
me some time in the future if I record that: applied, thanks!





More information about the pbs-devel mailing list