[pbs-devel] applied-series: [PATCH proxmox-backup v2 0/3] acme: add sleep for dns record propagation

[Thomas Lamprecht]

On 28.06.21 20:41, Stoiko Ivanov wrote:
> changes v1 -> v2 (based on Thomas' feedback - huge thx!):
> * moved the sleep to only run for setup not for teardown
> * added a check to only sleep and print the message if the delay is > 0
>   for consistency, and to be able to skip it (e.g. for a simple
>   powerdns-setup)
> * while looking through the code found a small glitch in an error
>   message (the fix is in patch 1/3)
> 
> forgot to mention that the patches were developed and tested on top of
> the current stable-1 branch (they apply cleanly on master, but I did not
> explicitly test on master)
> 
> cover-letter for v1:
> The issue was brought up in our community forum:
> https://forum.proxmox.com/threads/acme-configuration-via-gui.91381/
> 
> While I could not directly reproduce it (writing to a pdns-database is
> faster than waiting on cloud-flare to propagate their records) I
> compared the task-log to the one from PMG.
> 
> The use of tokio::time::sleep was taken from the other delays in
> api2::node::certificate, for the rest I mostly trusted the compiler
> warnings and rustfmt.
> 
> 
> Stoiko Ivanov (3):
>   acme: plugin: fix error message
>   config: acme: make validation_delay crate public
>   fix #3496: acme: plugin: add sleep for dns propagation
> 
>  src/acme/plugin.rs        | 19 +++++++++++++++++--
>  src/config/acme/plugin.rs |  2 +-
>  2 files changed, 18 insertions(+), 3 deletions(-)
> 



applied series, thanks!