[pbs-devel] [PATCH proxmox-backup 04/15] api2/tape: add missing protected to some api calls

Dominik Csapak d.csapak at proxmox.com
Wed Jan 27 11:33:50 CET 2021


they need root permission either to access the changer/drive or to
modify the config

Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
---
 src/api2/config/media_pool.rs |  3 +++
 src/api2/tape/backup.rs       |  1 +
 src/api2/tape/changer.rs      |  2 ++
 src/api2/tape/drive.rs        | 11 ++++++++++-
 src/api2/tape/media.rs        |  2 ++
 5 files changed, 18 insertions(+), 1 deletion(-)

diff --git a/src/api2/config/media_pool.rs b/src/api2/config/media_pool.rs
index d155f268..33e4993e 100644
--- a/src/api2/config/media_pool.rs
+++ b/src/api2/config/media_pool.rs
@@ -28,6 +28,7 @@ use crate::{
 };
 
 #[api(
+    protected: true,
     input: {
         properties: {
             name: {
@@ -153,6 +154,7 @@ pub enum DeletableProperty {
 }
 
 #[api(
+    protected: true,
     input: {
         properties: {
             name: {
@@ -231,6 +233,7 @@ pub fn update_pool(
 }
 
 #[api(
+    protected: true,
     input: {
         properties: {
             name: {
diff --git a/src/api2/tape/backup.rs b/src/api2/tape/backup.rs
index 6aa12d56..ea05e6a3 100644
--- a/src/api2/tape/backup.rs
+++ b/src/api2/tape/backup.rs
@@ -43,6 +43,7 @@ use crate::{
 };
 
 #[api(
+    protected: true,
    input: {
         properties: {
             store: {
diff --git a/src/api2/tape/changer.rs b/src/api2/tape/changer.rs
index 232f0127..f79a7ee0 100644
--- a/src/api2/tape/changer.rs
+++ b/src/api2/tape/changer.rs
@@ -33,6 +33,7 @@ use crate::{
 
 
 #[api(
+    protected: true,
     input: {
         properties: {
             name: {
@@ -106,6 +107,7 @@ pub async fn get_status(name: String) -> Result<Vec<MtxStatusEntry>, Error> {
 }
 
 #[api(
+    protected: true,
     input: {
         properties: {
             name: {
diff --git a/src/api2/tape/drive.rs b/src/api2/tape/drive.rs
index a88ef827..936bc528 100644
--- a/src/api2/tape/drive.rs
+++ b/src/api2/tape/drive.rs
@@ -68,6 +68,7 @@ use crate::{
 };
 
 #[api(
+    protected: true,
     input: {
         properties: {
             drive: {
@@ -150,6 +151,7 @@ pub async fn export_media(drive: String, label_text: String) -> Result<u64, Erro
 }
 
 #[api(
+    protected: true,
     input: {
         properties: {
             drive: {
@@ -313,6 +315,7 @@ pub async fn eject_media(drive: String) -> Result<(), Error> {
 }
 
 #[api(
+    protected: true,
     input: {
         properties: {
             drive: {
@@ -497,7 +500,8 @@ pub async fn restore_key(
     }).await?
 }
 
- #[api(
+#[api(
+    protected: true,
     input: {
         properties: {
             drive: {
@@ -575,6 +579,7 @@ pub async fn read_label(
 }
 
 #[api(
+    protected: true,
     input: {
         properties: {
             drive: {
@@ -793,6 +798,7 @@ pub fn update_inventory(
 
 
 #[api(
+    protected: true,
     input: {
         properties: {
             drive: {
@@ -911,6 +917,7 @@ fn barcode_label_media_worker(
 }
 
 #[api(
+    protected: true,
     input: {
         properties: {
             drive: {
@@ -938,6 +945,7 @@ pub fn cartridge_memory(drive: String) -> Result<Vec<MamAttribute>, Error> {
 }
 
 #[api(
+    protected: true,
     input: {
         properties: {
             drive: {
@@ -961,6 +969,7 @@ pub fn volume_statistics(drive: String) -> Result<Lp17VolumeStatistics, Error> {
 }
 
 #[api(
+    protected: true,
     input: {
         properties: {
             drive: {
diff --git a/src/api2/tape/media.rs b/src/api2/tape/media.rs
index 70af454c..d520288f 100644
--- a/src/api2/tape/media.rs
+++ b/src/api2/tape/media.rs
@@ -38,6 +38,7 @@ use crate::{
 };
 
 #[api(
+    protected: true,
     input: {
         properties: {
             pool: {
@@ -244,6 +245,7 @@ pub struct MediaContentListFilter {
 }
 
 #[api(
+    protected: true,
     input: {
         properties: {
             "filter": {
-- 
2.20.1






More information about the pbs-devel mailing list