[pbs-devel] applied series: [PATCH proxmox-backup 0/8] clippy fixes

[Wolfgang Bumiller]

applied series

On Wed, Jan 20, 2021 at 05:23:47PM +0100, Fabian Grünbichler wrote:
> non-trivial clippy fixes and stuff I found while fixing clippy issues.
> the remainder of warnings are now:
> 
> - one derive_hash_xor_eq (Authid)
> - one module_inception (rrd)
> - one missing_safety_docs
> - one wrong_self_convention (to_canonical_json not taking &self)
> - plenty complex types, too many arguments and missing Default impl when
> types have a fn new() without args
> 
> which require individual attention to decide whether to refactor/fix, or
> allow them.
> 
> when writing new commits, the following should cut down on the noise
> until all of the above are addressed:
> 
> $ cargo clippy -- --allow clippy::type_complexity --allow clippy::new_without_default --allow clippy::too_many_arguments
> 
> Fabian Grünbichler (8):
>   clippy: add is_empty() when len() is implemented
>   clippy: fix Mutex with unused value
>   clippy: rewrite comparison chains
>   clippy: rewrite ifs with identical return values
>   apt: let api handle optional bool with default
>   rework GC traversal error handling
>   http-client: fix typoed ticket cache condition
>   http-client: further clippy cleanups
> 
>  src/api2/access.rs             | 32 +++++++++++++-------------------
>  src/api2/backup/environment.rs |  4 +++-
>  src/api2/node/apt.rs           |  7 ++-----
>  src/api2/node/dns.rs           |  2 +-
>  src/api2/node/tasks.rs         | 16 ++++++----------
>  src/backup/chunk_store.rs      |  4 ++--
>  src/backup/chunk_stream.rs     |  7 ++-----
>  src/backup/datastore.rs        | 18 ++++++++++--------
>  src/client/http_client.rs      | 10 +++++-----
>  src/config/network/parser.rs   |  1 +
>  src/tools/acl.rs               |  9 +++++++--
>  src/tools/lru_cache.rs         |  5 +++++
>  12 files changed, 57 insertions(+), 58 deletions(-)
> 
> -- 
> 2.20.1