[pbs-devel] [PATCH proxmox-backup 1/8] clippy: add is_empty() when len() is implemented

Fabian Grünbichler f.gruenbichler at proxmox.com
Wed Jan 20 17:23:48 CET 2021


Signed-off-by: Fabian Grünbichler <f.gruenbichler at proxmox.com>
---
 src/tools/acl.rs       | 3 +++
 src/tools/lru_cache.rs | 5 +++++
 2 files changed, 8 insertions(+)

diff --git a/src/tools/acl.rs b/src/tools/acl.rs
index d9ae42a0..94f3f4df 100644
--- a/src/tools/acl.rs
+++ b/src/tools/acl.rs
@@ -322,6 +322,9 @@ impl ACLXAttrBuffer {
         self.buffer.len()
     }
 
+    /// The buffer always contains at least the version, it is never empty
+    pub const fn is_empty(&self) -> bool { false }
+
     /// Borrow raw buffer as mut slice.
     pub fn as_mut_slice(&mut self) -> &mut [u8] {
         self.buffer.as_mut_slice()
diff --git a/src/tools/lru_cache.rs b/src/tools/lru_cache.rs
index 19012976..ecd15ba6 100644
--- a/src/tools/lru_cache.rs
+++ b/src/tools/lru_cache.rs
@@ -184,6 +184,11 @@ impl<K: std::cmp::Eq + std::hash::Hash + Copy, V> LruCache<K, V> {
         self.map.len()
     }
 
+    /// Returns `true` when the cache is empty
+    pub fn is_empty(&self) -> bool {
+        self.map.is_empty()
+    }
+
     /// Get a mutable reference to the value identified by `key`.
     /// This will update the cache entry to be the most recently used entry.
     /// On cache misses, the cachers fetch method is called to get a corresponding
-- 
2.20.1






More information about the pbs-devel mailing list