[pbs-devel] applied-series: [PATCH proxmox-backup 0/6] tfa fixups

[Thomas Lamprecht]

On 13.01.21 12:06, Dominik Csapak wrote:
> fixed some of the more weird spacing/style issues i saw
> 
> there are still some issues, but maybe someone else can look at it:
> 
> * there is no gui for initial webauthn setup (which is mandatory)
> * The text 'Copy Secret Value' is weird, but i could not come up with
>   something better for now
> * on login, the text should not be 'OTP' for recovery keys, it should be
>   distinct, else it is very confusing
> * the spacing on the login windows and deletion confirm window is still
>   wrong
> * the deletion confirm window has the title 'Confirm Password', but as
>   root at pam, there is no password field (better only "Conifrm"?)

it is also weirdly formatted..

>   we maybe can reuse our 'Safe Destroy Window' here?
> * when i enter a wrong password, the error message is
> 
> AUTH_ERR (7)
> 
>   which is not informational, and not consistent with our login.
> * Some edit/add windows can be refactored using the Edit Window,
>   currently the functionality is duplicated across them
>   (addWebauthn, addTotp, etc.)
> * The warning that there are only few recovery codes left has too many
>   warning icons (one should be enough)
> * Sometimes i ran into an issue, where, if i have the recovery login
>   window open for too long, the code is not accepted. It was not very
>   clear to me if i can reuse that code again (i could) but that seems
>   to be bad ux, since normally a recovery code is not something i have
>   on hand, and it'll take a while until i found one.
> 
> 
> Dominik Csapak (6):
>   ui: LoginView: remove not used viewModel
>   ui: config/TfaView: disable Remove button by default
>   ui: window/AddTfaRecovery: rewrite to a Proxmox.window.Edit
>   ui: window/AddTfaRecovery: fix style of TfaRecoveryShow window
>   ui: window/AddTotp: fix spacing styling of form fields
>   ui: window/{AddWebauthn,TfaEdit}: fix spacing/border of the windows
> 
>  www/LoginView.js             |   8 ---
>  www/config/TfaView.js        |   1 +
>  www/window/AddTfaRecovery.js | 136 ++++++++++++-----------------------
>  www/window/AddTotp.js        |  81 ++++++++++-----------
>  www/window/AddWebauthn.js    |   2 +-
>  www/window/TfaEdit.js        |   1 -
>  6 files changed, 86 insertions(+), 143 deletions(-)
> 


applied series, much thanks for those initial fixes!

@Wolfgang, maybe you can also tackle a few of those when sending patches for adding
the initial setup part - after all the JS/gui part got pushed without any real review
by you ;P