[pbs-devel] applied: [PATCH proxmox-backup] api2/config/tape_backup_job: fix duplicate id parameter

Dietmar Maurer dietmar at proxmox.com
Wed Feb 24 10:47:46 CET 2021


> > Cant we simple omit fixed properties from the Updater?
> 
> I could try. I'd have to split out the Builder functionality of the Updatable
> trait, which is currently what allows `Option<T: Updatable>` to be generically
> implemented without specialization, but I could in theory generate implementations
> for Option types on the fly as well...
> (Currently there's a generic `impl Updatable for Option<T>` going like this:
> if the option is Some() already, then update_from(), otherwise try_build_from().)

I simply do not know how the current Updater is supposed to be used. Please can you provide
and example? 

The current code in src/api2/config/tape_backup_job.rs looks clumsy, and I am 
unsure if it works at all with multiple 'fixed' properties.





More information about the pbs-devel mailing list