[pbs-devel] [PATCH proxmox-backup 10/22] proxmox_client_tools: extract 'key' from client module

Dietmar Maurer dietmar at proxmox.com
Wed Feb 17 10:11:22 CET 2021


> On 02/16/2021 6:06 PM Stefan Reiter <s.reiter at proxmox.com> wrote:
> 
>  
> To be used by other command line tools. Requires moving XDG helpers as
> well, which find their place in the tools module quite cozily IMHO.
> 
> Signed-off-by: Stefan Reiter <s.reiter at proxmox.com>
> ---
>  src/bin/proxmox-backup-client.rs              | 440 +-----------------
>  src/bin/proxmox_backup_client/catalog.rs      |   4 +-
>  src/bin/proxmox_backup_client/mod.rs          |  30 --
>  src/bin/proxmox_backup_client/snapshot.rs     |   3 +-
>  .../key.rs                                    | 440 +++++++++++++++++-
>  src/bin/proxmox_client_tools/mod.rs           |  30 +-
>  6 files changed, 474 insertions(+), 473 deletions(-)
>  rename src/bin/{proxmox_backup_client => proxmox_client_tools}/key.rs (52%)

Also, this diff hides most code behind the rename.
This is extremely dangerous, and should be avoided (use an 
extra patch for renames).





More information about the pbs-devel mailing list