[pbs-devel] [PATCH proxmox-backup 1/3] ui: tape/TapeInventory: change to regular store

Dominik Csapak d.csapak at proxmox.com
Mon Feb 15 15:22:21 CET 2021


listing the media can potentially hang (changer status), so do not
reload in the background, only on activate

also increase the timeout to 5 minutes and add a reload button

Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
---
 www/tape/TapeInventory.js | 28 ++++++++++------------------
 1 file changed, 10 insertions(+), 18 deletions(-)

diff --git a/www/tape/TapeInventory.js b/www/tape/TapeInventory.js
index 4bac4072..c641e492 100644
--- a/www/tape/TapeInventory.js
+++ b/www/tape/TapeInventory.js
@@ -18,6 +18,7 @@ Ext.define('pbs-model-tapes', {
     proxy: {
 	type: 'proxmox',
 	url: '/api2/json/tape/media/list',
+	timeout: 5*60*1000,
     },
 });
 
@@ -71,35 +72,26 @@ Ext.define('PBS.TapeManagement.TapeInventory', {
 	},
 
 	reload: function() {
-	    this.getView().getStore().rstore.load();
-	},
-
-	stopStore: function() {
-	    this.getView().getStore().rstore.stopUpdate();
-	},
-
-	startStore: function() {
-	    this.getView().getStore().rstore.startUpdate();
+	    this.getView().getStore().load();
 	},
     },
 
     listeners: {
-	beforedestroy: 'stopStore',
-	deactivate: 'stopStore',
-	activate: 'startStore',
+	activate: 'reload',
     },
 
     store: {
-	type: 'diff',
-	rstore: {
-	    type: 'update',
-	    storeid: 'proxmox-tape-tapes',
-	    model: 'pbs-model-tapes',
-	},
+	storeid: 'proxmox-tape-tapes',
+	model: 'pbs-model-tapes',
 	sorters: 'label-text',
     },
 
     tbar: [
+	{
+	    text: gettext('Reload'),
+	    handler: 'reload',
+	},
+	'-',
 	{
 	    xtype: 'proxmoxButton',
 	    text: gettext('Set Tape Location'),
-- 
2.20.1






More information about the pbs-devel mailing list