[pbs-devel] applied-series: [PATCH proxmox-backup 1/3] ui: form/GroupFilter: correctly resolve the reference cycle

Thomas Lamprecht t.lamprecht at proxmox.com
Wed Dec 1 14:33:14 CET 2021


On 01.12.21 11:57, Dominik Csapak wrote:
> 'record[widget]' does not contain anything since the widgets are
> in the 'widgets' property so delete that
> 
> we also have to remove the 'record' entry of the widget so that
> the widget does not have a link to the record anymore
> 
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
>  www/form/GroupFilter.js | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
>

applied series, thanks! Added a patch that merges duplicate filter-entries
on top.

As mentioned off-list, ideally we'd let our combo grid cope with shared stores,
then we could use a single backing store for all group fields, which would be
more efficient too, anyhow, for now this is just fine as is.





More information about the pbs-devel mailing list