[pbs-devel] applied: Re: [PATCH proxmox-backup] ui: fix order of prune keep reasons

Thomas Lamprecht t.lamprecht at proxmox.com
Mon Aug 30 15:31:21 CEST 2021


Am 8/30/21 um 10:30 AM schrieb Dominik Csapak:
> two things wrong with the old code:
>  * the sort function wants -1, 0 and 1 as a return value for a<b, a==b and a>b
>    respectively, not a bool (which a < b returns)
>  * we have to sort the newest backups first, since the first reason is
>    'keep-last'. until now, we sorted the oldest backup first, resulting
>    in the older backups getting the 'keep-last' reason
> 
> reported by a user in the forum:
> https://forum.proxmox.com/threads/prune-ui-and-prune-schedule-simulator-dont-match.94944/
> 
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
>  www/datastore/Prune.js | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
>

I'd maybe went for an arrow function here, mostly to match the sorting in the prune-simulator,
but really does not matters mucht, if at all, so:

applied, thanks!





More information about the pbs-devel mailing list