[pbs-devel] [PATCH proxmox 1/2] api-macro: fix broken binary ident search

Dietmar Maurer dietmar at proxmox.com
Thu Sep 17 06:25:45 CEST 2020


> @@ -394,6 +397,9 @@ impl SchemaObject {
>  
>      fn sort_properties(&mut self) {
>          self.properties_.sort_by(|a, b| (a.0).cmp(&b.0));
> +        for (idx, prop) in self.properties_.iter().enumerate() {
> +            self.ident_hash.insert(prop.0.as_ident_str().to_string(), idx);
> +        }
>      }
>  

Above looks really wrong to me. Why should we repopulate the whole hash in sort_properties()?





More information about the pbs-devel mailing list