[pbs-devel] [RFC proxmox 1/5] time: add test for leap second parsing/converting

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Sep 15 13:35:42 CEST 2020


On 9/15/20 12:20 PM, Fabian Grünbichler wrote:
> Signed-off-by: Fabian Grünbichler <f.gruenbichler at proxmox.com>
> ---
> 
> Notes:
>     test fails, fixed by next patch
> 

off-topic, you and Dominik use this pattern to introduce test failure before
fixing it quite a bit, and I dislike it quite a bit.

Either just do the fix and the test in one patch, or re-order this so that
the fix comes first, then the previously failing test if you really think
it is semantically separate and needs to be a separate test...
We're all developers with at least a basic git experience, if one wants to
still check the prev. failure of the test anybody should be able to do that.

I do not want the build to fail at any commit.





More information about the pbs-devel mailing list