[pbs-devel] [PATCH 0/4] Improve corrupt chunk handling

Stefan Reiter s.reiter at proxmox.com
Mon Sep 7 11:31:10 CEST 2020


On 9/3/20 5:51 PM, Dietmar Maurer wrote:
> 
>> On 09/03/2020 5:40 PM Dietmar Maurer <dietmar at proxmox.com> wrote:
>>
>>   
>>> Verify will now rename chunks it detects as corrupted, so future backups will be
>>> forced to write them. The next GC will then clean these ".bad" files up, since
>>> it has to scan each chunk directory anyway.
>>
>> That sounds quite dangerous to me. What about transient storage errors?
> 
> Maybe I miss-read your path. When do you remove those .bad files exactly? Only when
> the client uploaded a good chunk already?
> 

Not currently, but I will make it so GC checks for a new good chunk 
before deleting the .bad one in v2.





More information about the pbs-devel mailing list