[pbs-devel] [PATCH 0/4] Improve corrupt chunk handling

Stefan Reiter s.reiter at proxmox.com
Thu Sep 3 16:17:01 CEST 2020


Verify will now rename chunks it detects as corrupted, so future backups will be
forced to write them. The next GC will then clean these ".bad" files up, since
it has to scan each chunk directory anyway.

In case the last backup uses some of these chunks, but is not the one that
failed verification, the client may still omit these chunks, which could lead to
a broken backup. The last patch detects these cases by checking all referenced
chunks for existance (which certainly adds a bit of overhead, especially to
otherwise minimal dirty-bitmap backups).


proxmox-backup: Stefan Reiter (4):
  verify: fix log units
  verify: rename corrupted chunks with .bad extension
  gc: remove .bad files on garbage collect
  backup: check all referenced chunks actually exist

 src/api2/backup/environment.rs | 21 ++++++++++++++++-
 src/api2/types/mod.rs          |  3 +++
 src/backup/chunk_store.rs      | 43 ++++++++++++++++++++++++----------
 src/backup/datastore.rs        |  5 +++-
 src/backup/verify.rs           | 34 +++++++++++++++++++++++++--
 5 files changed, 90 insertions(+), 16 deletions(-)

-- 
2.20.1





More information about the pbs-devel mailing list