[pbs-devel] applied: [PATCH proxmox-backup v2] server/worker_task: simplify task log writing

Thomas Lamprecht t.lamprecht at proxmox.com
Thu Oct 29 13:11:26 CET 2020


On 29.10.20 10:50, Dominik Csapak wrote:
> instead of prerotating 1000 tasks
> (which resulted in 2 writes each time an active worker was finished)
> simply append finished tasks to the archive (which will be rotated)
> 
> page cache should be good enough so that we can get the task logs fast
> 
> since existing installations might have an 'index' file, we
> still have to read tasks from there, but only if it exists
> 
> this simplifies the TaskListInfoIterator a good amount
> 
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
> we now write all finished tasks into the archive, as soon as
> any code tries to iterate over any finished task
> 
> this way we can remove most of the index handling code, besides
> that tiny bit of compatibility that we can drop with 1.x
> 
>  src/server/worker_task.rs | 91 +++++++++++++--------------------------
>  1 file changed, 29 insertions(+), 62 deletions(-)
> 
>

applied, thanks!





More information about the pbs-devel mailing list