[pbs-devel] [PATCH backup] api: add world accessible ping dummy endpoint

Thomas Lamprecht t.lamprecht at proxmox.com
Thu Oct 22 12:34:42 CEST 2020


On 22.10.20 10:18, Fabian Grünbichler wrote:
> On October 21, 2020 8:32 pm, Thomas Lamprecht wrote:
>> On 05.10.20 16:57, Thomas Lamprecht wrote:
>>> This is indented to be used for the PVE storage library, replacing
>>> the missuse of the much more expensive status API call.
>>>
>>> Signed-off-by: Thomas Lamprecht <t.lamprecht at proxmox.com>
>>> ---
>>>
>>> I initially thought about adding this to the proxmox-backup-client as command,
>>> but it's not much of use there (user can just use the version command) and for
>>> the PVE integration we can do a simple http request with LWP, which is much
>>> cheaper than fork+exec the client there.
>>>
>>
>> any objections to this? Else I'd apply it as is..
> 
> LGTM, maybe besides that having a separate file for this instead of just 
> inlining it into api2.rs seems overkill :-P
> 

Thought so first too, but it made the top level API entry point quite a bit uglier,
more noisier, and as the separate file does not costs much I went for that way :)






More information about the pbs-devel mailing list