[pbs-devel] [PATCH proxmox-backup 3/3] fix #2988: allow verification after finishing a snapshot

Dietmar Maurer dietmar at proxmox.com
Tue Oct 20 08:12:30 CEST 2020


> +            let verify = |env: BackupEnvironment| {
> +                // we are done, so we can safely drop the snapshot guard early
> +                // to allow the verify task to acquire it for itself

Instead, I would keepä the lock and use/expose "verify_backup_dir_no_lock()". Is that
feasible?


> +                std::mem::drop(_snap_guard);
> +                if let Err(err) = env.verify_after_complete() {
> +                    env.log(format!(
> +                        "backup finished, but starting the requested verify task failed: {}",
> +                        err
> +                    ));
> +                }
> +            };
> +
>              match (res, env.ensure_finished()) {





More information about the pbs-devel mailing list