[pbs-devel] [PATCH v2 proxmox-backup 2/4] datastore: add manifest locking

Dietmar Maurer dietmar at proxmox.com
Fri Oct 16 09:37:06 CEST 2020


> > -        let _guard;
> > +        let (_guard, _manifest_guard);
> >          if !force {
> >              _guard = lock_dir_noblock(&full_path, "snapshot", "possibly running or in use")?;
> > +            _manifest_guard = self.lock_manifest(backup_dir);
> 
> I think this is unnecessary. An update manifest should not block a remove_backup_dir.
> What for exactly?

Ok, Fabian just told be that this is required to avoid unexpected error messages,
so I will apply this now.





More information about the pbs-devel mailing list