[pbs-devel] applied: [PATCH v2 proxmox-backup 1/2] add extra_info field to APTUpdateInfo

Thomas Lamprecht t.lamprecht at proxmox.com
Wed Nov 11 18:33:47 CET 2020


On 10.11.20 14:22, Mira Limbeck wrote:
> Add an optional string field to APTUpdateInfo which can be used for
> extra information.
> 
> This is used for passing running kernel and running version information
> in the versions API call together with proxmox-backup and
> proxmox-backup-server.
> 
> Signed-off-by: Mira Limbeck <m.limbeck at proxmox.com>
> ---
> v2:
>     - renamed additional_info to extra_info to make it compatible with
>       GUI code
>     - changed the running_kernel and running_version info to contain the
>       text 'running kernel: ' and 'running version: ' which removes the
>       need for special casing in proxmox-backup-manager versions and
>       makes it again compatible with the GUI
> 
>  src/api2/node/apt.rs  | 35 ++++++++++++++++++++++++++++-------
>  src/api2/types/mod.rs |  2 ++
>  src/tools/apt.rs      |  1 +
>  3 files changed, 31 insertions(+), 7 deletions(-)
> 
>

applied, thanks! I did some followups restoring the format to the previous state,
line lengths up to 99 are fine for us, and reducing some lines can help read the
code faster as more is visible and thus in the mental state, at least it feels
less bloated to me :-)

Can you please address your comment on this patch as followup?






More information about the pbs-devel mailing list