[pbs-devel] applied: [PATCH proxmox-backup 2/2] bail if mount point already exists for directories

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Nov 10 09:37:58 CET 2020


On 05.11.20 14:36, Fabian Ebner wrote:
> similar to what we do for zfs. By bailing before partitioning, the disk is
> still considered unused after a failed attempt.
> 
> Signed-off-by: Fabian Ebner <f.ebner at proxmox.com>
> ---
> 
> There is no other caller for create_datastore_mount_unit, so the check from
> the not yet applied https://lists.proxmox.com/pipermail/pbs-devel/2020-November/001297.html
> is superseded by this.
> 
>  src/api2/node/disks/directory.rs | 22 +++++++++++++++++-----
>  1 file changed, 17 insertions(+), 5 deletions(-)
> 
>

applied, thanks!

maybe we should loosen this check a bit and also allow existing but empty
directories?  But for now OK, this is in a pretty specific namespace anyway.





More information about the pbs-devel mailing list