[pbs-devel] [PATCH proxmox-backup 4/5] api2/admin/datastore: start the garbage_collection task with our helper

Dominik Csapak d.csapak at proxmox.com
Tue Nov 3 07:54:55 CET 2020



On 11/3/20 6:45 AM, Dietmar Maurer wrote:
>> instead of manually, this has the advantage that we now set
>> the jobstate correctly and can return with an error if it is
>> currently running (instead of failing in the task)
> 
> We always send notifications now, even for manually triggered task.
> 
> So the behavior is finally inconsistent, i.e. we do not send notifications for
> manually triggered verify. Maybe we should change that too?
> 

ok well that was not really my intention, so we could simply add an 
option to do_garbage_collection_job ?

or as you said add them to manual verify too, im ok with both..





More information about the pbs-devel mailing list