[pbs-devel] applied: [PATCH proxmox-backup 0/5] various bug fixes/improvements for gc

[Thomas Lamprecht]

On 02.11.20 12:34, Dominik Csapak wrote:
> these are some improvements/fixes for the garbage_collection
> 
> Dominik Csapak (5):
>   garbage collect: improve index error messages
>   backup/{dynamic,fixed}_index: improve error message for small index
>     files
>   server/gc_job: add 'to_stdout'
>   api2/admin/datastore: start the garbage_collection task with our
>     helper
>   proxmox-backup-proxy: use only jobstate for garbage_collection
>     schedule
> 
>  src/api2/admin/datastore.rs     | 17 +++++------------
>  src/backup/datastore.rs         | 22 +++++++++++++++++++---
>  src/backup/dynamic_index.rs     | 20 +++++++++++++-------
>  src/backup/fixed_index.rs       | 19 +++++++++++++------
>  src/bin/proxmox-backup-proxy.rs | 23 ++++++-----------------
>  src/server/gc_job.rs            |  3 ++-
>  6 files changed, 58 insertions(+), 46 deletions(-)
> 



applied series, thanks!

Die two followups.
1. due to a patch of mine the UPID import in proxmox-backup-proxy
   was now unused, dropped that
2. This:

return Err(format_err!(
    "cannot open index {}: {}",
    full_path.to_string_lossy(),
    err,
));

is:

bail!("can't open index {} - {}", path.to_string_lossy(), err),


On another note, I had the feeling that we did not sent out mails for manually
triggered GCs before this change, not sure if I'm just imagine or if you changed
that, possibly unwillingly?