[pbs-devel] [PATCH 0/5] fix #2881: protect base snapshots and avoid races

Stefan Reiter s.reiter at proxmox.com
Wed Jul 29 14:33:09 CEST 2020


Avoid races with GC and between different concurrent backups by limiting the
number of concurrent backups per group to 1 and forbidding the deletion of the
previous finished backup, if a new one is currently running.

Fixes several issues that could lead to failed backups, or even worse,
"successful" backups that were really missing chunks.


proxmox-backup: Stefan Reiter (5):
  fix typo: avgerage to average
  datastore: prevent deletion of snaps in use as "previous backup"
  tools: add nonblocking mode to lock_file
  backup: use flock on backup group to forbid multiple backups at once
  backup: ensure base snapshots are still available after backup

 src/api2/admin/datastore.rs     |  4 +--
 src/api2/backup.rs              | 12 +++++---
 src/api2/backup/environment.rs  | 23 +++++++++++++--
 src/backup/backup_info.rs       | 51 ++++++++++++++++++++++++++++++++-
 src/backup/datastore.rs         | 43 +++++++++++++++++++++++++--
 src/backup/prune.rs             |  2 +-
 src/bin/proxmox-backup-proxy.rs |  2 +-
 src/client/backup_writer.rs     |  2 +-
 src/client/pull.rs              |  4 +--
 src/tools.rs                    | 13 +++++++++
 10 files changed, 140 insertions(+), 16 deletions(-)

-- 
2.20.1





More information about the pbs-devel mailing list