[pbs-devel] applied: [PATCH qemu] Fix dirty-bitmap PBS backup with multiple drives

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Jul 14 11:04:46 CEST 2020


On 14.07.20 10:45, Stefan Reiter wrote:
> "PVE backup: rename incremental to use-dirty-bitmap" merged two
> variables (use_dirty_bitmap and incremental) into one, but they served
> two different purposes. Rename the original use_dirty_bitmap to
> "expect_only_dirty" so the new one doesn't conflict, and rework "PVE:
> use proxmox_backup_check_incremental" around that semantic.
> 
> In practice, this had the effect that only one disk at a time would
> have a bitmap added, as after the first "use_dirty_bitmap" would be set
> to one and the rest would behave as if the QMP parameter of the same
> name was unset.
> 
> Signed-off-by: Stefan Reiter <s.reiter at proxmox.com>
> ---
> 
> I changed it in the original patches to avoid a fixup on top of fixups, hope
> that's good.
> 
>  ...name-incremental-to-use-dirty-bitmap.patch | 27 ++++++++--------
>  ...irty-counter-for-non-incremental-bac.patch |  6 ++--
>  ...use-proxmox_backup_check_incremental.patch | 31 ++++++++-----------
>  3 files changed, 30 insertions(+), 34 deletions(-)
> 
>

applied, thanks!





More information about the pbs-devel mailing list