[pbs-devel] applied: Re: [PATCH proxmox-backup] add local-zfs.rst

Oguz Bektas o.bektas at proxmox.com
Thu Jul 9 10:37:53 CEST 2020


On Wed, Jul 08, 2020 at 06:21:16PM +0200, Thomas Lamprecht wrote:
> On 08.07.20 14:41, Oguz Bektas wrote:
> > content is > 90% same as local-zfs.adoc in pve-docs.
> > 
> > adapted the format for .rst
> > 
> > fixed some typos and wrote some parts slightly different (wording).
> > 
> > Signed-off-by: Oguz Bektas <o.bektas at proxmox.com>
> > ---
> >  docs/local-zfs.rst | 374 +++++++++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 374 insertions(+)
> >  create mode 100644 docs/local-zfs.rst
> > 
> >
> 
> applied, but there's quite a few things to fix. What reStructured text really likes
> are a empty line between a special directive and its content. For example, code-block:
> 
> >.. code-block:: console
> >
> >  options zfs zfs_arc_max=8589934592
> 
> You missed that empty line everywhere. Simple tables have also some rules to follow.

oh. sorry about that, will keep in mind for nex time

> 
> I Included this in sysadmin.rst and move that out as it's own chapter.
thanks!





More information about the pbs-devel mailing list