[pbs-devel] [RFC 0/2] backup client: implement some HTTP timeouts

Stefan Reiter s.reiter at proxmox.com
Mon Dec 21 14:56:09 CET 2020


Not a comprehensive overhaul, but should fix the most common hangs to at least
finish *sometime*. Tested on an intentionally slow PBS with VM backups - QEMU
still hangs, but resumes to work after 20 seconds as intended.

20 seconds was chosen by fair dice roll, seems to be a good limit for opening an
HTTP connection (so not counting actual data transfer)?

Disclaimer: The 'proxmox' patches were a *bit* over my head, so I hope the
generics and stuff make sense, appreciate any feedback there - it's certainly
interesting to play with higher-level Rust like this, would love to learn :)


proxmox: Stefan Reiter (1):
  add tools::future with TimeoutFutureExt

 proxmox/src/tools/future.rs | 48 +++++++++++++++++++++++++++++++++++++
 proxmox/src/tools/mod.rs    |  1 +
 2 files changed, 49 insertions(+)
 create mode 100644 proxmox/src/tools/future.rs

proxmox-backup: Stefan Reiter (1):
  http_client: add timeouts for critical connects

 src/client/http_client.rs | 17 ++++++++++++++---
 1 file changed, 14 insertions(+), 3 deletions(-)

-- 
2.20.1




More information about the pbs-devel mailing list