[pbs-devel] applied: Re: [PATCH proxmox-backup v2] tools/daemon: improve reload behaviour

Thomas Lamprecht t.lamprecht at proxmox.com
Fri Dec 18 10:31:36 CET 2020


On 17/12/2020 15:50, Dominik Csapak wrote:
> it seems that sometimes, the child process signal gets handled
> before the parent process signal. Systemd then ignores the
> childs signal (finished reloading) and only after going into
> reloading state because of the parent. this will never finish.
> 
> Instead, wait for the state to change to 'reloading' after sending
> that signal in the parent, an only fork afterwards. This way
> we ensure that systemd knows about the reloading before actually trying
> to do it.
> 
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
> changes from v1:
> * introduce wait_service_is_(not_)state
>     it is a bit more generic
>     has a better name
> * factor the common code out into get_service_state
> 
>  src/tools/daemon.rs | 45 ++++++++++++++++++++++++++++-----------------
>  1 file changed, 28 insertions(+), 17 deletions(-)
> 
>

applied, with Fabians T-b, thanks!




More information about the pbs-devel mailing list