[pbs-devel] [PATCH v2 backup] fix #2909: handle missing chunks gracefully in garbage collection

Oguz Bektas o.bektas at proxmox.com
Wed Aug 5 12:22:15 CEST 2020


instead of bailing and stopping the entire GC process, warn about the
missing chunks and continue.

this results in "TASK WARNINGS: X" as the status.

Signed-off-by: Oguz Bektas <o.bektas at proxmox.com>
---
 src/backup/datastore.rs | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/backup/datastore.rs b/src/backup/datastore.rs
index ffd64b81..1565712c 100644
--- a/src/backup/datastore.rs
+++ b/src/backup/datastore.rs
@@ -436,8 +436,8 @@ impl DataStore {
             tools::fail_on_shutdown()?;
             let digest = index.index_digest(pos).unwrap();
             if let Err(err) = self.chunk_store.touch_chunk(digest) {
-                bail!("unable to access chunk {}, required by {:?} - {}",
-                      proxmox::tools::digest_to_hex(digest), file_name, err);
+                worker.warn(&format!("warning: unable to access chunk {}, required by {:?} - {}",
+                      proxmox::tools::digest_to_hex(digest), file_name, err));
             }
         }
         Ok(())
-- 
2.20.1





More information about the pbs-devel mailing list