[pbs-devel] [PATCH proxmox-backup] gui: user: fix #2898 add dialog to set password

Aaron Lauterer a.lauterer at proxmox.com
Mon Aug 3 11:45:30 CEST 2020



On 7/30/20 10:22 AM, Dominik Csapak wrote:
> works as intended, one nit inline
> 
> other than that:
> 
> Reviewed-By: Dominik Csapak <d.csapak at proxmox.com>
> Tested-By: Dominik Csapak <d.csapak at proxmox.com>
> 
>> +
>> +    getValues: function(dirtyOnly) {
>> +    var me = this;
>> +
>> +    var values = me.callParent(arguments);
>> +
>> +    return values;
>> +    },
> 
> if we only call callParent, is it necessary to have it at all?

You are right. Forgot to strip that after copy and pasta. Will send a v2.





More information about the pbs-devel mailing list